Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #61 - 스탬프 삭제, 초기화 Domain, Data 및 Network 구현 #65

Merged
merged 8 commits into from
Jan 1, 2023
Merged

[Feat] #61 - 스탬프 삭제, 초기화 Domain, Data 및 Network 구현 #65

merged 8 commits into from
Jan 1, 2023

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • ListDetail(fetchStamp, putStamp, postStamp, deleteStamp) 네트워크 연결
  • resetStamp 연결
  • AlertVC 수정

📌 참고 사항

🚨앞의 풀리퀘 #62 머지한 다음에 봐주세여 ! 커밋이 포함되어 있어서 조금 정신 없을 수 있습니다 ..

AlertVC에 type별로 분리했습니다

public enum AlertType {
    case title // 타이틀 + 취소 버튼 + 커스텀 버튼
    case titleDescription // 타이틀 + 설명 + 취소 버튼 + 커스텀 버튼
    case networkErr // 타이틀 + 설명 + 확인 버튼(다른 케이스의 취소 버튼과 동일)
}

네트워크 오류 alert의 경우
아래처럼 바로 factory에서 불러서 사용하시면 됩니다

let alertVC = factory.makeNetworkAlertVC()

그 외의 alert를 사용하는 경우

let alertVC = self.factory.makeAlertVC(
            type: .title,
            title: I18N.ListDetail.deleteTitle,
            description: "", // 설명을 사용하지 않는 경우 빈 스트링을 넣어주세요
            customButtonTitle: I18N.Default.delete)

let alertVC = self.factory.makeAlertVC(
            type: .titleDescription,
            title: I18N.ListDetail.deleteTitle,
            description: "안녕하세요",
            customButtonTitle: I18N.Default.delete)

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

@yangsubinn yangsubinn added Feat 새로운 기능 구현 양수🌷 labels Dec 29, 2022
@yangsubinn yangsubinn self-assigned this Dec 29, 2022
@yangsubinn
[Merge] develop pull
4495343 
Merge branch 'develop' of https://github.com/sopt-makers/SOPT-Stamp-iOS into feat/sopt-makers#61-DeleteStampNetwork
@yangsubinn
Copy link
Member Author

@L-j-h-c @devxsby @lsj8706 #62 머지했슴다 봐주십셔 ..

lsj8706
lsj8706 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AlertVC 만들어주신 거 잘 사용하겠습니다 ㅎㅎ

L-j-h-c
L-j-h-c approved these changes Jan 1, 2023
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 슨상님...!

SOPT-Stamp-iOS/Projects/Modules/Network/Sources/Service/StampService.swift Outdated
Comment on lines 41 to 47
let subject = PassthroughSubject<Int, Error>()
requestObjectWithNoResult(StampAPI.deleteStamp(stampId: stampId)) { result in
result.success { statusCode in
subject.send(statusCode ?? 0)
}
}
return subject.eraseToAnyPublisher()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오...혹시 요렇게 구현해야했던 이유가 있을까요...? 아래에 주석이 있길래...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아이고 이거 지우고 아래꺼 주석 풀어서 올리겠슴다 !
combine으로 된게 없는 줄 알고 저러케 했었는데 있어서 수정했다가 .. 머 해본다구 주석 걸고 고대로 올렸나봐여 .. 😅

SOPT-Stamp-iOS/Projects/Presentation/Sources/SettingScene/VC/SettingVC.swift Outdated
Comment on lines 56 to 59
.sink { success in
if success {
self.showToast(message: I18N.Setting.resetSuccess)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기에는 filter를 사용해도 좋을 것 같네용~~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네넹 !

devxsby
devxsby approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 빙수선배. 🤍

@yangsubinn yangsubinn merged commit 68422a1 into sopt-makers:develop Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

Assignees

@yangsubinn yangsubinn

Labels
Feat 새로운 기능 구현 size/L 양수🌷
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 스탬프 삭제(개별/전체) Network 구현
4 participants
@yangsubinn @L-j-h-c @lsj8706 @devxsby